Merge pull request #118 from DLHub-Argonne/flake8-fixes

Fix flake8
DLHub-Argonne · Sep 17, 2021 · 9216f0a · 9216f0a
2 parents 783bee7 + 2c90544
commit 9216f0a
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 52 deletions.
diff --git a/.github/workflows/CI.yml b/.github/workflows/CI.yml
@@ -82,9 +82,9 @@ jobs:
 
       - name: Lint with flake8
         run: |
-          # stop the build if there are Python syntax errors or undefined names
-          flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
-          # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
+          # stop the build if there are any-flake8 comments
+          flake8 dlhub_sdk
+          # Warn us about complexity
           flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics
       - name: Test with pytest
         run: |

diff --git a/dlhub_sdk/models/servables/keras.py b/dlhub_sdk/models/servables/keras.py
@@ -119,7 +119,6 @@ def create_model(cls, model_path, output_names=None, arch_path=None,
 
         # Add keras as a dependency
         keras_version = keras.__version__
-        _keras_version_tuple = tuple(int(i) for i in keras_version.rstrip("-tf").split("."))
         if not (keras_version.endswith("-tf") or use_tf_keras):
             output.add_requirement('keras', keras_version)
         output.add_requirement('h5py', 'detect')

diff --git a/dlhub_sdk/models/servables/tests/test_tensorflow.py b/dlhub_sdk/models/servables/tests/test_tensorflow.py
@@ -13,10 +13,7 @@
 except ImportError:
     tf_installed = False
 
-
-
-
-no_tf = pytest.mark.skipif(tf_installed == False, reason='tf not installed')
+no_tf = pytest.mark.skipif(not tf_installed, reason='tf not installed')
 
 # Do not write to a temp directory so I can see it outside of tests
 tf_export_path = os.path.join(os.path.dirname(__file__), 'tf-model')

diff --git a/dlhub_sdk/utils/tests/test_futures.py b/dlhub_sdk/utils/tests/test_futures.py