Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename t8 cmesh vtk #450

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Rename t8 cmesh vtk #450

merged 4 commits into from
Mar 7, 2023

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Mar 6, 2023

With the upcoming PRs I will add a vtk-reader. To distinguish between reader and writer I renamed the file t8_cmesh_vtk to
t8_cmesh_vtk_writer.
In the upcoming PRs, I will add a vtk-reader.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Knapp added 4 commits February 22, 2023 15:48
In the upcoming PRs we will add a vtk reader and want to prevent this file from blowing up.
Therefore I specified the file-name, changed the headers in other files and will soon add a
t8_cmesh_vtk_reader.h
@Davknapp Davknapp added enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins labels Mar 6, 2023
@chiaraMaHe chiaraMaHe self-assigned this Mar 6, 2023
@Davknapp Davknapp changed the base branch from main to merge-queue-test March 7, 2023 11:14
@Davknapp Davknapp enabled auto-merge March 7, 2023 11:16
@Davknapp Davknapp added this pull request to the merge queue Mar 7, 2023
Merged via the queue into merge-queue-test with commit 98f0047 Mar 7, 2023
@Davknapp Davknapp deleted the rename-t8_cmesh_vtk- branch March 7, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code shouldn't take long Can be resolved in under 30 mins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants