Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cmesh vtk reader implementation [vtk_to_cmesh 5/6] #466

Merged
merged 9 commits into from
May 11, 2023

Conversation

Davknapp
Copy link
Collaborator

Implemented a reader, that opens a vtk-file and reads the data into a vtkSmartPointer.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

@Davknapp Davknapp changed the title Cmesh vtk reader implementation [vtk_to_cmesh 5/x] Cmesh vtk reader implementation [vtk_to_cmesh 5/6] Mar 13, 2023
@Davknapp Davknapp added this to In progress in vtk-reader Mar 13, 2023
@Davknapp Davknapp added the New feature Adds a new feature to the code label Mar 13, 2023
@Davknapp Davknapp marked this pull request as draft March 13, 2023 15:24
@Davknapp Davknapp added the draft Enhance the visibility that this is a draft. label Mar 17, 2023
@Davknapp Davknapp removed their assignment Mar 17, 2023
@jmark jmark self-assigned this May 8, 2023
@jmark
Copy link
Collaborator

jmark commented May 9, 2023

@Davknapp Es gibt noch enige Merge-Konflikte, die aufgelöst werden müssen.

Yes, they just occured due to work on the preceeding PR. As soon as it is merged I will handle the conflicts.

@jmark jmark assigned Davknapp and unassigned jmark May 9, 2023
Base automatically changed from vtk_polydata_reader to main May 10, 2023 11:17
@Davknapp Davknapp marked this pull request as ready for review May 11, 2023 09:29
@Davknapp Davknapp requested a review from jmark May 11, 2023 09:29
@Davknapp Davknapp assigned jmark and unassigned Davknapp May 11, 2023
@Davknapp Davknapp linked an issue May 11, 2023 that may be closed by this pull request
src/t8_cmesh/t8_cmesh_vtk_reader.cxx Outdated Show resolved Hide resolved
test/t8_IO/t8_gtest_vtk_reader.cxx Show resolved Hide resolved
vtk-reader automation moved this from In progress to Review in progress May 11, 2023
@jmark jmark assigned Davknapp and unassigned jmark May 11, 2023
@Davknapp Davknapp requested a review from jmark May 11, 2023 12:06
@Davknapp Davknapp assigned jmark and unassigned Davknapp May 11, 2023
vtk-reader automation moved this from Review in progress to Reviewer approved May 11, 2023
@jmark jmark merged commit 00a1823 into main May 11, 2023
3 checks passed
vtk-reader automation moved this from Reviewer approved to Done May 11, 2023
@jmark jmark deleted the cmesh_vtk_reader_implementation branch May 11, 2023 13:30
jfussbro pushed a commit to jfussbro/t8code that referenced this pull request Jun 27, 2023
…tation

Cmesh vtk reader implementation [vtk_to_cmesh 5/6]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Enhance the visibility that this is a draft. New feature Adds a new feature to the code
Projects
vtk-reader
  
Done
Development

Successfully merging this pull request may close these issues.

Building error with VTK
2 participants