Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated pyra-tests #497

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Updated pyra-tests #497

merged 3 commits into from
Mar 29, 2023

Conversation

Davknapp
Copy link
Collaborator

The pyra-test has not been properly indented and the google-test-framework was not used as intended - this PR fixes it.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

@Davknapp Davknapp added shouldn't take long Can be resolved in under 30 mins tests cleanup Cleans the code labels Mar 28, 2023
@jmark jmark merged commit 138d910 into main Mar 29, 2023
@jmark jmark deleted the indent_pyra_test branch March 29, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Cleans the code shouldn't take long Can be resolved in under 30 mins tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants