Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split vtk_writer_function[2/2] Add forest_to_vtkUnstructuredGrid function #510

Merged
merged 11 commits into from
Jun 12, 2023

Conversation

Davknapp
Copy link
Collaborator

@Davknapp Davknapp commented Apr 5, 2023

This function makes vtk_writing a 2 step procedure (while still providing the original usage of the writer-function) and enables us to write vtkUnstructuredGrids, which can be used to directly communicate with ParaView.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

  • The author added a BSD statement to doc/ (or already has one)

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)
  • All tests pass (in various configurations, this should be executed automatically in a github action)

  • New source/header files are properly added to the Makefiles

  • New Datatypes are added to t8indent_custom_datatypes.txt

  • The reviewer executed the new code features at least once and checked the results manually

  • The code is covered in an existing or new test case

  • New tests use the Google Test framework

  • The code follows the t8code coding guidelines

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.

  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

@Davknapp Davknapp added enhancement Enhances already existing code draft Enhance the visibility that this is a draft. labels Apr 5, 2023
@Davknapp Davknapp added this to In progress in vtk-reader via automation Apr 5, 2023
@Davknapp Davknapp changed the base branch from main to update-vtk_writer April 5, 2023 11:37
@jmark jmark self-assigned this May 8, 2023
Base automatically changed from update-vtk_writer to main May 23, 2023 12:55
@jmark jmark marked this pull request as ready for review May 23, 2023 13:02
src/t8_forest/t8_forest_to_vtkUnstructured.hxx Outdated Show resolved Hide resolved
src/t8_forest/t8_forest_to_vtkUnstructured.hxx Outdated Show resolved Hide resolved
vtk-reader automation moved this from In progress to Review in progress May 23, 2023
@jmark jmark assigned Davknapp and unassigned jmark May 23, 2023
Co-authored-by: Johannes Markert <10619309+jmark@users.noreply.github.com>
@Davknapp Davknapp assigned jmark and unassigned Davknapp May 26, 2023
src/t8_forest/t8_forest_to_vtkUnstructured.hxx Outdated Show resolved Hide resolved
src/t8_forest/t8_forest_to_vtkUnstructured.hxx Outdated Show resolved Hide resolved
@jmark jmark assigned Davknapp and unassigned jmark May 26, 2023
Co-authored-by: Johannes Markert <10619309+jmark@users.noreply.github.com>
@Davknapp Davknapp assigned jmark and unassigned Davknapp May 26, 2023
@jmark jmark enabled auto-merge May 26, 2023 12:48
vtk-reader automation moved this from Review in progress to Reviewer approved Jun 12, 2023
@jmark jmark merged commit 6fa856a into main Jun 12, 2023
3 checks passed
@jmark jmark deleted the split_vtk_writer branch June 12, 2023 14:52
vtk-reader automation moved this from Reviewer approved to Done Jun 12, 2023
jfussbro pushed a commit to jfussbro/t8code that referenced this pull request Jun 27, 2023
Split vtk_writer_function[2/2] Add forest_to_vtkUnstructuredGrid function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draft Enhance the visibility that this is a draft. enhancement Enhances already existing code
Projects
vtk-reader
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants