Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added constness to flags #571

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

edirab
Copy link
Contributor

@edirab edirab commented May 30, 2023

Added constness to flags

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp
Copy link
Collaborator

Thanks for your contribution! Can you add a BSD-Statement to the doc-file? You can use the same wording as in author_knapp.txt.
The statement holds for future PRs as well, if we merge this one.

@edirab
Copy link
Contributor Author

edirab commented May 31, 2023

Thanks for your contribution! Can you add a BSD-Statement to the doc-file? You can use the same wording as in author_knapp.txt. The statement holds for future PRs as well, if we merge this one

No problem, done

@Davknapp Davknapp merged commit dd4e57a into DLR-AMR:main May 31, 2023
3 checks passed
@Davknapp
Copy link
Collaborator

Thanks for your contribution! Are you working on a project using t8code?

@edirab
Copy link
Contributor Author

edirab commented May 31, 2023

No, just contributing to open source as much as I can

@Davknapp
Copy link
Collaborator

Davknapp commented Jun 1, 2023

That is very nice of you!

jfussbro pushed a commit to jfussbro/t8code that referenced this pull request Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants