Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the translation of an element to a vtkCell into a seperate function #592

Merged
merged 5 commits into from
Jun 29, 2023

Conversation

Davknapp
Copy link
Collaborator

Preperation for ghost-cells via vtkAPI
Moved the translation of the elements into a seperate function to avoid code-duplication for ghost-cell writing.

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp added the enhancement Enhances already existing code label Jun 27, 2023
@Davknapp Davknapp mentioned this pull request Jun 27, 2023
15 tasks
@ililikakis ililikakis self-requested a review June 27, 2023 11:51
@ililikakis ililikakis self-assigned this Jun 27, 2023
src/t8_forest/t8_forest_vtk.cxx Outdated Show resolved Hide resolved
src/t8_forest/t8_forest_vtk.cxx Outdated Show resolved Hide resolved
@ililikakis ililikakis assigned Davknapp and unassigned ililikakis Jun 27, 2023
Davknapp and others added 2 commits June 27, 2023 14:14
Co-authored-by: Ioannis Lilikakis <73935606+ililikakis@users.noreply.github.com>
Co-authored-by: Ioannis Lilikakis <73935606+ililikakis@users.noreply.github.com>
@Davknapp Davknapp assigned ililikakis and unassigned Davknapp Jun 27, 2023
@Davknapp Davknapp requested a review from ililikakis June 27, 2023 12:14
src/t8_forest/t8_forest_vtk.cxx Outdated Show resolved Hide resolved
@ililikakis ililikakis assigned Davknapp and unassigned ililikakis Jun 27, 2023
Co-authored-by: Ioannis Lilikakis <73935606+ililikakis@users.noreply.github.com>
@Davknapp Davknapp assigned ililikakis and unassigned Davknapp Jun 28, 2023
@Davknapp Davknapp requested a review from ililikakis June 28, 2023 08:46
@ililikakis ililikakis merged commit a76a752 into main Jun 29, 2023
3 checks passed
@ililikakis ililikakis deleted the Move_element_to_vtk_cell_translation branch June 29, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhances already existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants