Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update indentation src-t8_geometry #704

Merged

Conversation

chiaraMaHe
Copy link
Collaborator

Describe your changes here:

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • New Datatypes are added to t8indent_custom_datatypes.txt
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

Licence

  • The author added a BSD statement to doc/ (or already has one)

@Davknapp Davknapp self-assigned this Aug 23, 2023
Copy link
Collaborator

@Davknapp Davknapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address my comment. Apart from this topic the PR is ready to merge

src/t8_geometry/t8_geometry_base.hxx Outdated Show resolved Hide resolved
@Davknapp Davknapp assigned chiaraMaHe and unassigned Davknapp Aug 23, 2023
@chiaraMaHe chiaraMaHe added this to Needs a Review in Update formatting to clang Aug 23, 2023
@chiaraMaHe chiaraMaHe assigned Davknapp and unassigned chiaraMaHe Aug 24, 2023
@Davknapp Davknapp assigned chiaraMaHe and unassigned Davknapp Aug 24, 2023
@chiaraMaHe chiaraMaHe assigned jmark and Davknapp and unassigned jmark and chiaraMaHe Aug 24, 2023
@Davknapp Davknapp merged commit f6a3121 into feature-new_script_to_indent_our_source_code Aug 25, 2023
1 check passed
Update formatting to clang automation moved this from Needs a Review to Done Aug 25, 2023
@Davknapp Davknapp deleted the update-src-t8_geometry branch August 25, 2023 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants