Skip to content

Commit

Permalink
Fix sde_sample_freq for SAC (#32)
Browse files Browse the repository at this point in the history
* Fix `sde_sample_freq` for SAC

* [ci skip] Add Acknowledgments
  • Loading branch information
araffin committed May 24, 2020
1 parent 3da0d14 commit 9b42b97
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 3 deletions.
6 changes: 6 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -227,5 +227,11 @@ Stable-Baselines3 is currently maintained by [Ashley Hill](https://github.com/hi
To any interested in making the baselines better, there is still some documentation that needs to be done.
If you want to contribute, please read [**CONTRIBUTING.md**](./CONTRIBUTING.md) guide first.

## Acknowledgments

The initial work to develop Stable Baselines3 was partially funded by the project *Reduced Complexity Models* from the *Helmholtz-Gemeinschaft Deutscher Forschungszentren*.

The original version, Stable Baselines, was created in the [robotics lab U2IS](http://u2is.ensta-paristech.fr/index.php?lang=en) ([INRIA Flowers](https://flowers.inria.fr/) team) at [ENSTA ParisTech](http://www.ensta-paristech.fr/en).


Logo credits: [L.M. Tenkes](https://www.instagram.com/lucillehue/)
3 changes: 2 additions & 1 deletion docs/misc/changelog.rst
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
Changelog
==========

Pre-Release 0.6.0a9 (WIP)
Pre-Release 0.6.0a10 (WIP)
------------------------------

Breaking Changes:
Expand All @@ -24,6 +24,7 @@ Bug Fixes:
- Fixed a bug that prevented model trained on cpu to be loaded on gpu
- Fixed version number that had a new line included
- Fixed weird seg fault in docker image due to FakeImageEnv by reducing screen size
- Fixed ``sde_sample_freq`` that was not taken into account for SAC

Deprecations:
^^^^^^^^^^^^^
Expand Down
2 changes: 1 addition & 1 deletion stable_baselines3/common/base_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -798,7 +798,7 @@ def collect_rollouts(self,

while not done:

if self.use_sde and self.sde_sample_freq > 0 and n_steps % self.sde_sample_freq == 0:
if self.use_sde and self.sde_sample_freq > 0 and total_steps % self.sde_sample_freq == 0:
# Sample a new noise matrix
self.actor.reset_noise()

Expand Down
2 changes: 1 addition & 1 deletion stable_baselines3/version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.6.0a9
0.6.0a10

0 comments on commit 9b42b97

Please sign in to comment.