Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Function to compute area of fuselage section #259

Closed
rainman110 opened this issue Jun 24, 2017 · 2 comments
Closed

New Function to compute area of fuselage section #259

rainman110 opened this issue Jun 24, 2017 · 2 comments
Labels
Priority-High
Milestone
TiGL 3.0

Comments

@rainman110
Copy link
Collaborator

rainman110 commented Jun 24, 2017 •
edited

We need a function that computes the area of a fuselage section.

How to do:

Proposed API:

tiglFuselageGetCrossSectionArea(handle, fuselageSegmentUID, eta, &area)
@rainman110 rainman110 added this to the TiGL 3.0 milestone Jun 24, 2017
@CLiersch
Copy link

I would recommend to name the function
tiglFuselageGetCrossSectionArea(handle, fuselageSegmentUID, eta, &area)
because I think it is more intuitive easier to distinguish from other areas

@rainman110
Copy link
Collaborator Author

I would recommend to name the function
tiglFuselageGetCrossSectionArea(handle, fuselageSegmentUID, eta, &area)
because I think it is more intuitive easier to distinguish from other areas

@CLiersch Yes, this seems to be reasonable. I updated the issue.

rainman110 added a commit that referenced this issue Jul 1, 2017
@rainman110
Changed function to compute fuselage cross section
b03aea0 
Instead of using boolean operations, I chose to use
iso-v curves of the fuselage surfaces.

Addresses #259 and #260
rainman110 added a commit that referenced this issue Jul 1, 2017
@rainman110
Changed function to compute fuselage cross section
5b99a44 
Instead of using boolean operations, I chose to use
iso-v curves of the fuselage surfaces.

Addresses #259 and #260
hereToCreate pushed a commit to hereToCreate/tigl that referenced this issue Jul 7, 2017
Added API func. tiglFuselageGetCrossSectionArea
3a29514 
The function tiglFuselageGetCrossSectionArea is committed which
computes the area of a fuselage section. A helper function GetArea
which computes the area of a TopoDS_Shape and the test for
tiglFuselageGetCrossSectionArea are committed as well.

Fixes issue DLR-SC#259
@hereToCreate hereToCreate mentioned this issue Jul 7, 2017
Merged
hereToCreate pushed a commit to hereToCreate/tigl that referenced this issue Jul 10, 2017
Test for API func tiglFuselageGetCrossSectionArea
caaadab 
The test for the function tiglFuselageGetCrossSectionArea is
enhanced, i.e., the arguments for EXPECT_NEAR() are in the right
order now and M_PI is used instead of a double variable.

Fixes issue DLR-SC#259
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority-High
Projects
None yet
Milestone
TiGL 3.0
Development

No branches or pull requests
2 participants
@rainman110 @CLiersch