Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot handle more than 3 wing guide curves #687

Closed
rainman110 opened this issue Jun 4, 2020 · 5 comments
Closed

Cannot handle more than 3 wing guide curves #687

rainman110 opened this issue Jun 4, 2020 · 5 comments
Projects
TiGL 3.2

Comments

@rainman110
Copy link
Collaborator

Currently, e.g. the wing surface names cannot be determined correctly, leading to many following problems.
rainman110 added a commit that referenced this issue Jun 4, 2020
@rainman110
Correctly map wing surface names in case of more than 3 guide curves
2700903 
Addresses #687
rainman110 added a commit that referenced this issue Jun 4, 2020
@rainman110
Fixed compilation with g++
5f29e2a 
Addresses #687
rainman110 added a commit that referenced this issue Jun 4, 2020
@rainman110
Removed log message
f7cfa51 
Addresses #687
@rainman110
Copy link
Collaborator Author

rainman110 commented Jun 4, 2020 •
edited

This issue is larger than thought intially. Many places assume a single face for a segment upper or lower side, e.g.:

  • CCPACSWingSegment::GetPoint
  • CCPACSWingSegment::GetSurfaceArea
  • CCPACSWingSegment::GetIsOnTop

All require a GeomSurface. Probably the easiest way would be to merge the different subsurfaces into on surface.

rainman110 added a commit that referenced this issue Sep 29, 2020
@rainman110
Correctly map wing surface names in case of more than 3 guide curves
428ec53 
Addresses #687
rainman110 added a commit that referenced this issue Sep 29, 2020
@rainman110
Fixed compilation with g++
2c97df4 
Addresses #687
rainman110 added a commit that referenced this issue Sep 29, 2020
@rainman110
Removed log message
6d32abf 
Addresses #687
rainman110 added a commit that referenced this issue Oct 9, 2020
@rainman110
Concatenate surfaces to make getpoint working
5c1653c 
This commit concatenates the surfaces of a segment
to provide a single surface to make the GetPoint
functions work.

Addresses #687
@rainman110
Copy link
Collaborator Author

As of rev 5c1653c, it is now possible to use the get point on the FFD with multiple guide curves:

GetPointMultipleGuideCurves

@rainman110
Copy link
Collaborator Author

We still have tests failing though!

@rainman110
Copy link
Collaborator Author

There was a copy & paste bug. No this is also fixed. I still need some more unit tests though 😄

rainman110 added a commit that referenced this issue Oct 15, 2020
@rainman110
Correctly map wing surface names in case of more than 3 guide curves
97317ee 
Addresses #687
rainman110 added a commit that referenced this issue Oct 15, 2020
@rainman110
Fixed compilation with g++
6d3c4e1 
Addresses #687
rainman110 added a commit that referenced this issue Oct 15, 2020
@rainman110
Removed log message
7a7cf22 
Addresses #687
rainman110 added a commit that referenced this issue Oct 15, 2020
@rainman110
Concatenate surfaces to make getpoint working
28e3709 
This commit concatenates the surfaces of a segment
to provide a single surface to make the GetPoint
functions work.

Addresses #687
@rainman110
Copy link
Collaborator Author

Implemened in TIGL 3.2. Closing the issue

@rainman110 rainman110 added this to To do in TiGL 3.2 via automation May 28, 2021
@rainman110 rainman110 moved this from To do to Done in TiGL 3.2 May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
TiGL 3.2
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rainman110