Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WingCell.getLoft() error when using contour coordinates on cells spanning several segments #829

Closed
joergbrech opened this issue Sep 24, 2021 · 1 comment · Fixed by #832
Assignees
Labels
Milestone

Comments

@joergbrech
Copy link
Contributor

When using the get_loft method with larger models, an unusual behavior occurred: with a small test case (Beam_Composite_Export_Test_32_cell2.xml) with one segment, the get_loft method works for several cells. In a larger test case with several segments (IEA-10.0-198-RWT_CPACS_contour_coordinates.xml), only the cells on the first segment are created correctly. Is that a bug or can only one segment be used with the contour coordinate definition of the cells?

CPACS.zip

Originally posted by @hardt-fa-flb in #815 (comment)

@joergbrech
Copy link
Contributor Author

This looks like a bug, but I am not 100% sure what is going on yet.

Principally, the contour coordinates support cells that span several segments, but the code behind it is quite complicated, because we have to track the topology of all faces across all segments that are potentially part of the cell, together with their parametric ranges in local u-v-coordinates and in global contour coordinates. In consequence, it is very likely that the code contains bugs.

Thanks for the test file. I will check it out.

@joergbrech joergbrech self-assigned this Sep 24, 2021
@joergbrech joergbrech added the bug label Sep 24, 2021
@joergbrech joergbrech assigned joergbrech and unassigned joergbrech Sep 28, 2021
joergbrech added a commit that referenced this issue Sep 28, 2021
joergbrech added a commit that referenced this issue Sep 28, 2021
@joergbrech joergbrech mentioned this issue Sep 28, 2021
5 tasks
@rainman110 rainman110 added this to the TiGL 3.2.2 milestone Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants