Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot define Trailing Edge border of a cell by referencing spar #864

Closed
joergbrech opened this issue Dec 14, 2021 · 0 comments · Fixed by #867
Closed

Cannot define Trailing Edge border of a cell by referencing spar #864

joergbrech opened this issue Dec 14, 2021 · 0 comments · Fixed by #867

Comments

@joergbrech
Copy link
Contributor

The problem is that CCPACSWingCell::CutChordWise always uses the leading edge spar as a cutting shape. We need to differentiate between leading edge and trailing edge here:

tigl/src/wing/CCPACSWingCell.cpp

Lines 772 to 773 in f20dcb7

// we can use the cutting shape defined by the spar
cuttingShape = m_uidMgr->ResolveObject<CCPACSWingSparSegment>(m_positioningLeadingEdge.GetSparUId())

joergbrech added a commit that referenced this issue Dec 14, 2021
@joergbrech
add test for #864
f6c421b
joergbrech added a commit that referenced this issue Dec 14, 2021
@joergbrech
fix #864
48d19fe
@joergbrech joergbrech mentioned this issue Dec 14, 2021
Merged
5 tasks
rainman110 added a commit that referenced this issue Dec 17, 2021
@rainman110
Merge pull request #867 from DLR-SC/864-wingcell-te-spar-bug
14731e9 
Fix #864
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #864 DLR-SC/tigl
1 participant
@joergbrech