Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TiGL crashes when <guidecurves> node has no children nodes. #962

Closed
AntonReiswich opened this issue Apr 24, 2023 · 1 comment · Fixed by #984
Closed

TiGL crashes when <guidecurves> node has no children nodes. #962

AntonReiswich opened this issue Apr 24, 2023 · 1 comment · Fixed by #984
Assignees
Labels

Comments

@AntonReiswich
Copy link
Contributor

Bug description

TiGL crashes when node has no children nodes. This shouldn't happen. Insted, an error message should be printed.

@joergbrech joergbrech self-assigned this Nov 22, 2023
@joergbrech joergbrech added the bug label Nov 22, 2023
@joergbrech
Copy link
Contributor

This only happens for wings and not for fuselages. The problem is that CTiglWingBuilder::SetFaceTraits requires the guide curve parameters as argument. Internally it checks wether the guide curve parameters are empty or not, so that is fine.

The problem arises when CCPACSWingSegment or CTiglWingBuilder query the guide curve parameters to call SetFaceTraits: This indirectly calls CCPACSGuideCurves::GetRelativeCircumferenceParameters which has an implicit assumption that the parameters relCircs are not empty:

if (std::abs(relCircs.back() - 1.0) >= 1e-3 ) {

joergbrech added a commit that referenced this issue Dec 15, 2023
joergbrech added a commit that referenced this issue Dec 15, 2023
joergbrech added a commit that referenced this issue Dec 15, 2023
joergbrech added a commit that referenced this issue Dec 22, 2023
joergbrech added a commit that referenced this issue Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants