Added API function tiglFuselageGetSectionCenter #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A function for computing fuselage section center is committed. Fixes issue DLR-SC#260
rainman110
requested changes
Jul 6, 2017
src/api/tigl.cpp
Outdated
| TopoDS_Shape curve = segment.getWireOnLoft(eta); | ||
|
|
||
| // get linear properties of the ISO curve | ||
| GProp_GProps LProps; |
There was a problem hiding this comment.
Please put the next 5 lines into a separate function in tiglcommonfunctions.
tests/tiglFuselageSegment.cpp
Outdated
| EXPECT_NEAR(pointZ, 0, 1e-2); | ||
|
|
||
| ASSERT_EQ(TIGL_UID_ERROR, tiglFuselageGetSectionCenter(tiglHandle, "segmentD150_Fuselaggg_1Segment2ID", eta, &pointX, &pointY, &pointZ)); | ||
| ASSERT_EQ(TIGL_NULL_POINTER, tiglFuselageGetSectionCenter(tiglHandle, "segmentD150_Fuselage_1Segment2ID", eta, NULL, &pointY, &pointZ)); |
There was a problem hiding this comment.
Please add more tests for NULL pointers and a test for an invalid handle.
src/api/tigl.cpp
Outdated
| @@ -62,6 +62,8 @@ | |||
| #include "gp_Pnt.hxx" | |||
| #include "TopoDS_Shape.hxx" | |||
| #include "TopoDS_Edge.hxx" | |||
| #include "GProp_GProps.hxx" | |||
There was a problem hiding this comment.
Remove these includes, after putting the code into a separate function.
Some lines in tiglFuselageGetSectionCenter are bundled in a helper function. The test for this method is enhanced. Fixes issue DLR-SC#260
rainman110
requested changes
Jul 6, 2017
tests/tiglFuselageSegment.cpp
Outdated
| ASSERT_EQ(TIGL_NULL_POINTER, tiglFuselageGetSectionCenter(tiglHandle, "segmentD150_Fuselage_1Segment2ID", eta, &pointX, NULL, NULL)); | ||
| ASSERT_EQ(TIGL_NULL_POINTER, tiglFuselageGetSectionCenter(tiglHandle, "segmentD150_Fuselage_1Segment2ID", eta, NULL, NULL, NULL)); | ||
|
|
||
| ASSERT_EQ(TIGL_NOT_FOUND, tiglFuselageGetSectionCenter(-1, "segmentD150_Fuselage_1Segment2ID", eta, &pointX, &pointY, &pointZ)); |
There was a problem hiding this comment.
Can you please add tests for the following use cases:
- fuselageSegmentUID is NULL -> TIGL_NULL_POINTER
- eta < 0 - >TIGL_MATH_ERROR
- eta > 1 - >TIGL_MATH_ERROR
There was a problem hiding this comment.
@hereToCreate Could you also add one test for the second fuselage segment? Just to make sure, that the segment transformation works as expected.
src/api/tigl.h
Outdated
| @@ -1523,6 +1523,27 @@ TIGL_COMMON_EXPORT TiglReturnCode tiglGetFuselageCount(TiglCPACSConfigurationHan | |||
| TIGL_COMMON_EXPORT TiglReturnCode tiglFuselageGetSegmentCount(TiglCPACSConfigurationHandle cpacsHandle, | |||
| int fuselageIndex, | |||
| int* segmentCountPtr); | |||
| /** | |||
There was a problem hiding this comment.
Please add a blank line between the previous function and the comment block.
added 2 commits
July 7, 2017 10:03
The test for tiglFuselageGetSectionCenter tests another fuselage segment now and more error codes are returned in case of the corresponding errors and the method itself. Fixes issue DLR-SC#260
Added Error LOGs in the function tiglFuselageGetSectionCenter. Fixes issue DLR-SC#260
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function for computing fuselage section center is committed.
Fixes issue #260