Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C code #23

Merged
merged 1 commit into from
Jun 26, 2014
Merged

Fix C code #23

merged 1 commit into from
Jun 26, 2014

Conversation

tbeu
Copy link
Contributor

@tbeu tbeu commented Jun 24, 2014

  • Remove superfluous headers
  • Remove superfluous defines and type definitions
  • Introduce NOISE_LCG_MULTIPLIER
  • Fix comment style
  • Add trailing newline
  • Include stdint.h if available
  • Fix arguments of NOISE_shuffleDouble

Please test!

@tbeu tbeu mentioned this pull request Jun 25, 2014
Closed
@tbeu
Copy link
Contributor Author

tbeu commented Jun 26, 2014

@sjoelund and authors: Updated patch includes proposed fix from #24 to use stdint.h. It also fixes the arguments of NOISE_shuffleDouble.

Compilation was tested with MSVC6, VS2010, BCC55 on Win and GCC 4 on Linux.

@sjoelund
Copy link
Contributor

Pretty good, though I would prefer a typedef rather than a define (or using uint32_t directly, unless stdint.h was not available).

@tbeu
Copy link
Contributor Author

tbeu commented Jun 26, 2014

Sure, but typedef fails on BCC55 why I changed it back to macro.

@tbeu
Fix C code
a8e59de 
 * Remove superfluous headers
 * Remove superfluous defines and type definitions
 * Introduce NOISE_LCG_MULTIPLIER
 * Fix comment style
 * Add trailing newline
 * Include stdint.h if available
 * Fix arguments of NOISE_shuffleDouble

Please test!
@tbeu
Copy link
Contributor Author

tbeu commented Jun 26, 2014

@sjoelund OK, fixed in updated patch.

@sjoelund
Copy link
Contributor

I closed #23 in favour of this patch

@akloeckner
Copy link
Collaborator

Thanks a lot! The patch works here, too. I will go ahead and merge it!

akloeckner added a commit that referenced this pull request Jun 26, 2014
@akloeckner
Merge pull request #23 from tbeu/fix-c-file
9b57476 
Fix C code
@akloeckner akloeckner merged commit 9b57476 into DLR-SR:master Jun 26, 2014
@tbeu tbeu deleted the fix-c-file branch June 26, 2014 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tbeu @sjoelund @akloeckner