Pull request to add in support for morphological operations #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added in morphology operations from opencv on MRI images.
Added in opencv as a requirement for python 3.6
added in changes to elastic transform code to apply same changes to image-mask pair or different changes, based on random seed value provided by user. Also allowed processing an list of images rather than a single image, and returning the same processed list to the caller.
fixing indentation
fixing pep8 issues
fixing pesky w503 issues
|
Hi, |
|
hi, thanks for your response. No worries, i can try to achieve the same functionality with SimpleITK without resorting to using opencv, for the reasons you mentioned above. i will close this PR. Could you also take a look at the other change i made to augmentation.py (for which i have commented under #31)? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I believe users would greatly benefit from performing morphological operations (erosion, dilation, opening, closing, morphological gradient, top_hat and black_hat) on medical images, and have added these in preprocessing.py. I have also added in opencv as a dependency in setup.py and requirements,txt.
All these have been edited under dltk/contrib. I would appreciate if you could take a look and merge it if you think it would help the DLTK platform.