Improve _mm_srai_epi32 to handle complex arguments #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Complex arguments are not always handled properly by _mm_srai_epi32. Arguments like below will properly evaluate input[i] = _mm_srai_epi32(input[i], new_sqrt2_bits - 1 + shift); This also resolves 5 failing tests [ FAILED ] 5 tests, listed below: [ FAILED ] TX_ASM/InvTxfm2dAsmTest.sqr_txfm_match_test/0, where GetParam() = (0x102c7b198, 8) [ FAILED ] TX_ASM/InvTxfm2dAsmTest.sqr_txfm_match_test/1, where GetParam() = (0x102c7b198, 10) [ FAILED ] TX_ASM/InvTxfm2dAsmTest.lowbd_txfm_match_test/0, where GetParam() = (0x102c7b198, 8) [ FAILED ] TX_ASM/InvTxfm2dAddTest.svt_av1_inv_txfm_add/0, where GetParam() = (0x102c7d800, 8) [ FAILED ] SSE4_1/AV1SelfguidedFilterTest.CorrectnessTest/0, where GetParam() = (0x102cd4f20)
Developer-Ecosystem-Engineering
requested review from
jserv and
marktwtn
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complex arguments are not always handled properly by _mm_srai_epi32.
Arguments like below will properly evaluate
input[i] = _mm_srai_epi32(input[i], new_sqrt2_bits - 1 + shift);This also resolves 5 failing tests