Remove designated initialization of an array #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
C supports designated initialization of arrays, but C++ does not. The one usage of it does not serve a functional purpose and so can be removed. This code was triggering warnings under clang and errors under MSVC.
Cuda-Chen
reviewed
Oct 19, 2022
|
There are numerous other changes required for a clean MSVC build. This PR is specifically addressing warnings with clang. |
Got it. Then I consider this change is acceptable. |
Cuda-Chen
approved these changes
Oct 19, 2022
|
Thank @invertego for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C supports designated initialization of arrays, but C++ does not. The one usage of it does not serve a functional purpose and so can be removed. This code was triggering warnings under clang and errors under MSVC.