-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Cover all immediate numbers #584
Conversation
@jserv Do you think this PR is a good idea? I think even though this PR covers all the possible immediate numbers, the implementation become less readable and harder to implement. |
Alternatively, we can even generate test cases via shell scripts with more flexibility. |
May I ask for more details? |
Check this: https://github.com/IBM/microprobe/tree/master/targets/riscv/examples |
I didn't see the templates for SSE. I saw only PowerPC and RISCV only. Not sure how can we generate tests by this. I may need more research |
03b58b9
to
6cce1bb
Compare
So the current change is an acceptable one or I should discard it? |
I will extend the same implementation to the other instrinsics with immediate numbers |
This PR use X-Macro skill to iterate all the possible immediate numbers for the intrinsics that allow immediate numbers only.
closes #582