Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Key Generation x out of y Nodes #1

Closed
SurfingNerd opened this issue Apr 21, 2021 · 1 comment
Closed

Support for Key Generation x out of y Nodes #1

SurfingNerd opened this issue Apr 21, 2021 · 1 comment

Comments

@SurfingNerd
Copy link
Collaborator

Currently the Key Generation scripts only support networks where every generated node is also an initial validator.
(Location: crates/ethcore/src/engines/hbbft/hbbft_config_generator)

This makes automation in testing very hard.
We need to be able to create testnets where we add validators later on.

Current call:

cargo run -- 8 Docker

Creates a configuration with 8 nodes, every node becomes an initial validator.
This call should be equivilant with futures call

cargo run -- 8 8 Docker

but also support the setup of having less initial validators.

cargo run -- 2 8 Docker
This call should Setup a Testnet with 2 initial Validators, 8 Nodes in Total (6 are regular nodes)

SurfingNerd added a commit to SurfingNerd/openethereum-3.x that referenced this issue Apr 21, 2021
SurfingNerd added a commit to SurfingNerd/honey-badger-testing that referenced this issue Apr 22, 2021
@SurfingNerd
Copy link
Collaborator Author

dforsten pushed a commit to dforsten/openethereum-3.x that referenced this issue Apr 28, 2021
SurfingNerd added a commit that referenced this issue Aug 30, 2021
This fix was already tested with the "announce availability" transactions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant