Widget lister does not work correctly

[AntonMezger]

Hi,

In my case the lister had only one page and I had to make minor corrections in two files to have it working correctly. You did not have the correct count for numrows, so the lister had only the first page. My corrections are joined, I used a variable totalnumberofrows to keep the number of records. By the way in fetchdata of the class.tx_mkforms_ds_db_Main.php, the number of records is not calculated correctly, so I modified that too.

I hope you will integrate these changes in the latest release.

Please give me some feedback

best regards

listeredit_user.zip

[hannesbochmann]

@AntonMezger Would you mind providing a pull request?

[AntonMezger]

Hi, What do you mean? I provided a zip file with the changed files of version 9.5. I am not using a fork of your mkforms. I gust try to make my site working again. Btw return of array with majix routines does not work anymore when upgrading from version 3 to version 9.Best regardsDr sc. Anton C. MezgerStöckmattstrasse 145316 LeuggernLe 15 déc. 2022 à 11:47, Hannes Bochmann ***@***.***> a écrit : @AntonMezger Would you mind providing a pull request? —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>

[hannesbochmann]

A pull request makes it much easier to check and incorporate your changes. Especially a review is teadious without it. As we are short on time this would speed up including your changes.
Would you please open a seperate issue concering the majix routines providing more information like the class and method/line which is affected.

[AntonMezger]

I will create a project on github beginning of newxt week. for the majix problem I will create also this weekend an issue.

The changes I made to the above mentioned files are of course quick and dirty, so that you will have to do that your proper way. However they worked for me. The main problem you had is that for may entries in lister only the first page was present.

Best regards

Anton

[AntonMezger]

Hi Hannes,

I created on github the following repository, you will find my actual changes there. Please give me feedback about these.

https://github.com/AntonMezger/sdgziel.git

best regards

Anton

[hannesbochmann]

Sorry but this doesn't make it easier to incorporate your changes. Please have a look at this document: https://gist.github.com/MarcDiethelm/7303312

As we are busy as everyone we have no time to extract to necessary changes for this issue.

[AntonMezger]

Sorry about that, but I am not making any developments, but just wanted to point out a problem and an eventuel fix.

The fix I did was in class.tx_mkforms_ds_db_Main.php and in class.tx_mkforms_widgets_list_Main.php. You must be aware of the fact that count($rows) gives number 0 back, therfore I count in the foreach loop.

[AntonMezger]

the main problm with the lister is that you threw out the function gettotalNumberOfRows that would give the right amount of data. In your case you request always so many data as fits on a page. That wont' work. you should enable that function again in order to get the non-limited amount of data. (in class.tx_mkforms_ds_db_Main.php