Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The check of Members@odata.nextLink seems incorrect in Assertion 6.5.23.1 #81

Closed
cactusjiang opened this issue Mar 1, 2018 · 0 comments · Fixed by #92
Closed

The check of Members@odata.nextLink seems incorrect in Assertion 6.5.23.1 #81

cactusjiang opened this issue Mar 1, 2018 · 0 comments · Fixed by #92
Assignees

Comments

@cactusjiang
Copy link

This assertion is strange. It fails when Sessions has no members. If we post a new session, it passes. But for EventDestination Collection which has no member as well, it passes.

URI Members Result
/redfish/v1/SessionService/Sessions No FAIL, property Members@odata.nextLink should be present in the resource Root Service_Links_Sessions
Yes PASS
/redfish/v1/EventService/Subscriptions No PASS
Yes PASS

Look source code of Assert 6.5.23.1 and find the if statement if count<=member_count: taking true when a collection has no members (count = member_count = 0), and check whether there's next link property. It does not make sense the next link property be present in this case.

The count is not reset for each iteration, so the result would be incorrect. This is why the assertion passes when there's no member in EventDestination collection.

>> loop N-1
Resource uri: /redfish/v1/Registries
count = 36, member_count = 4

>> loop N
Resource uri: /redfish/v1/EventService/Subscriptions
count = 36, member_count = 0  <-- the count should be zero
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants