Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add per-request hooks #48

Merged
merged 1 commit into from Apr 13, 2023

Conversation

williamboman
Copy link
Contributor

@williamboman williamboman commented Apr 11, 2023

I also took the opportunity to add some EmmyLua type annotations, let me know if you want to remove these!

Closes #47.

@DNLHC
Copy link
Owner

DNLHC commented Apr 11, 2023

Hey, cool feature I like the idea!
I'm actually in the process of covering the project with type annotations, so your PR is very much welcome, thanks a lot!
So far I've partially covered list and winbar modules, so there won't be any conflicts.

offtopic: Do you know if there is a way to infer a type from a built-in neovim function, for example get the return type of vim.lsp.util.make_position_params function, or do i need to provide the types myself?

@williamboman
Copy link
Contributor Author

offtopic: Do you know if there is a way to infer a type from a built-in neovim function, for example get the return type of vim.lsp.util.make_position_params function, or do i need to provide the types myself?

Hm no I don't think that's possible currently. There's the @module annotation, so the closest I could get to was @module 'vim.lsp.util'.

@williamboman williamboman marked this pull request as ready for review April 13, 2023 07:57
@DNLHC
Copy link
Owner

DNLHC commented Apr 13, 2023

Looks good, thank you

@DNLHC DNLHC merged commit 77ebd26 into DNLHC:master Apr 13, 2023
@williamboman williamboman deleted the feat/per-request-hooks branch April 19, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Specify per-request hooks
2 participants