Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on download notification after module upgrade #57

Closed
stetard opened this issue Nov 7, 2023 · 1 comment · Fixed by #59
Closed

Error on download notification after module upgrade #57

stetard opened this issue Nov 7, 2023 · 1 comment · Fixed by #59

Comments

@stetard
Copy link
Contributor

stetard commented Nov 7, 2023

Describe the bug

After upgrade the module from 3.5.6 to 4.1.1, the file download doesn't work anymore.

Software Versions

  • DNN: 09.13.00
  • Module: 04.01.01

To Reproduce

Steps to reproduce the behavior:

  1. Upgrade an old website using the 3.5.6 version to the 4.1.1
  2. Click on the download link for a file listed by an existing module (created with the old version)
  3. The error message is:
    [NullReferenceException: Object reference not set to an instance of an object.]
    DotNetNuke.Modules.Repository.Repository.SendDownloadNotification(RepositoryInfo objRepository)

Expected behavior

User should obtain the selected file when clicking on the download link.

@stetard
Copy link
Contributor Author

stetard commented Nov 7, 2023

I think this issue is caused by the feature #42 which can send notifications when a user downloads a file.
In my case, the module settings haven't been updated manualy nor programaticaly.
I will provide a fix which will consist to test if the corresponding setting exists in the database before using its value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant