Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#58 Keep backward compatibility for upgraded modules that contains some customized storage locations #60

Merged

Conversation

stetard
Copy link
Contributor

@stetard stetard commented Nov 8, 2023

Description of PR...

Changed the code to take into account some potentials customized storage locations for upgraded modules.

Changes made

  • Settings Form: add the ability to display customized locations instead of the defaults
  • Helpers: introduce Default values for the 3 storage locations and compare them to the current module settings to use the corrects values.

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Close #58

@maduranga001
Copy link

Please, can somebody share the DLL file which includes all the last changes? Thank you so much.

Copy link
Member

@valadas valadas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing sticks out to me, thanks.

@valadas valadas merged commit cfa809c into DNNCommunity:develop Dec 8, 2023
1 check passed
@valadas valadas added the bug Something isn't working label Dec 8, 2023
@valadas valadas added this to the 4.1.2 milestone Dec 8, 2023
@stetard
Copy link
Contributor Author

stetard commented Dec 8, 2023

@maduranga001 you can download my dll at https://www.aricie.com/DotNetNuke.Modules.Repository.dll_patched.zip if needed.

@maduranga001
Copy link

@maduranga001 you can download my dll at https://www.aricie.com/DotNetNuke.Modules.Repository.dll_patched.zip if needed.

404 - File or directory not found.
Please, can you check and give me the correct link?
Thank you!

@stetard
Copy link
Contributor Author

stetard commented Dec 8, 2023

Sorry, it's a wrong url.
The correct url is https://download.aricie.com/DotNetNuke.Modules.Repository.dll_patched.zip

@maduranga001
Copy link

maduranga001 commented Dec 8, 2023 via email

@valadas
Copy link
Member

valadas commented Dec 8, 2023

I have just released a new version here if you want the full package https://github.com/DNNCommunity/DNN.Repository/releases/tag/v4.1.2

@maduranga001
Copy link

maduranga001 commented Dec 8, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change regarding the files storage location
3 participants