Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AddThis #167

Closed
WillStrohl opened this issue Nov 18, 2022 · 1 comment · Fixed by #171
Closed

Remove AddThis #167

WillStrohl opened this issue Nov 18, 2022 · 1 comment · Fixed by #171
Labels
enhancement New feature or request
Milestone

Comments

@WillStrohl
Copy link
Member

Is your feature request related to a problem?

There is a feature that allows end-users to optionally choose to share the page using a third-party tool called AddThis. The intent of such a feature is great, but this probably shouldn't have ever been added as a feature in this module.

There are too many ways to implement the addition of a content-sharing feature like this. Including what should be the correct (best practice) way in this case - adding it to the theme and/or creating a theme object that is added to the theme.

Regardless, the module shouldn't be doing this and it usually should be done at the page-level.

Describe the solution you'd like

Unless we can find a valid use case to do otherwise... We should remove this feature entirely, including all API, UI, and schema that supports it.

Describe alternatives you've considered

None at this time.

Additional context

If implemented, this may be a breaking change for anyone that might be using this feature. For example, many website owners operate on a "it works so don't touch it" kind of style. So, they'll upgrade thinking the sharing feature is still there, only to find out it's not any longer. Now, they'll have to scramble to figure out how to implement AddThis in another way.

@WillStrohl WillStrohl added the enhancement New feature or request label Nov 18, 2022
@Timo-Breumelhof
Copy link
Contributor

Agreed, IMO any kind of tracker should be implemented from the template.
BTW addthis is totally not GDPR compliant.

@johnhenley johnhenley added this to the 07.00.02 milestone Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants