Remove AddThis integration

[johnhenley]

Remove AddThis integration

Changes made

• Remove AddThis integration

PR Template Checklist

• Fixes Bug
• Feature solution
• Other

Please mark which issue is solved

Close #167

[WillStrohl]

Awesome PR, @johnhenley ! (as always...)

The only thing I see missing is the cleanup file and component update in the manifest file. Do you want me to add that for you later?

[johnhenley]

Awesome PR, @johnhenley ! (as always...)

The only thing I see missing is the cleanup file and component update in the manifest file. Do you want me to add that for you later?

Hi @WillStrohl. Please add them. I didn't think a cleanup was needed since no files were removed?

Also this isn't meant to be a real release but I wanted to avoid the sqlprovider collisions that I created last time with multiple PRs using same version number. So I made this one 07.00.02. And I'm reserving 07.01.00 for the big kahuna PR that is coming for template changes #93. And any small intervening ones can be 07.0.xx.

[Timo-Breumelhof]

Sounds good :-) But Shouldn't we go to V8 for the template changes?
As it's a breaking change?

[WillStrohl]

Yes, ideally, breaking changes should not be in a minor or point release. So, should the next release be a major release?

[Timo-Breumelhof]

When it contains the template change IMO it should be a major release.

[WillStrohl]

I agree with semantic versioning... I'm simply asking if we should target a major release for our next release. 😁

[johnhenley]

When it contains the template change IMO it should be a major release.

Changing the storage location of templates might not be considered a breaking change. For new installations and upgrades, it's transparent but gives administrators option of editing templates by editing the files. Editing in the control panel still works. Same for moving themes out of desktopmodules. It's handled during installation and upgrades and doesn't require intervention. As long as it's well-tested and documented properly--that certain things have changed--like file names and locations. Just my two cents 😀

[johnhenley]

I agree with semantic versioning... I'm simply asking if we should target a major release for our next release. 😁

I'm undecided 😀. On the one hand if we do, we're burning thru version numbers which is not good. But if we don't, we might be breaking something that people are using. Example is addthis. We've announced its removal and no feedback. I don't consider that a breaking change. If we release it as a minor release and document it, isn't that good enough?

[Timo-Breumelhof]

I agree it would be a bit fast on the other hand I so think it's a major change..

[WillStrohl]

I don't think it's possible for us to run out of version numbers. :D Let's keep the current version and adjust later based on the updates we see queued up, ready to be tested for release. That should work for our process for now... Right?

[Timo-Breumelhof]

Agreed, let's decide later

[johnhenley]

@WillStrohl can you approve this?