Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TASK: Inconsistent variable naming conventions #330

Closed
johnhenley opened this issue Jun 20, 2023 · 0 comments · Fixed by #331
Closed

TASK: Inconsistent variable naming conventions #330

johnhenley opened this issue Jun 20, 2023 · 0 comments · Fixed by #331
Assignees
@johnhenley
Labels
technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Milestone
08.00.00

Comments

@johnhenley
Copy link
Collaborator

Description of task

Incorrect variable names:

  • SiteId rather than PortalId
  • InstanceId rather than ModuleId

What general area(s)/component(s) are affected?

** check any / all **
[] User interface
[] Database schema
[] Business Logic
[] Dependencies
[] Installation/manifest
[X] Other
@johnhenley johnhenley added the technical debt Issue that doesn't directly affect usability but will improve technical debt posture label Jun 20, 2023
@johnhenley johnhenley added this to the 08.00.03 milestone Jun 20, 2023
@johnhenley johnhenley self-assigned this Jun 20, 2023
@johnhenley johnhenley mentioned this issue Jun 20, 2023
Merged
3 tasks
@johnhenley johnhenley changed the title Inconsistent variable naming conventions TASK: Inconsistent variable naming conventions Jun 24, 2023
@johnhenley johnhenley modified the milestones: 08.00.03, 08.00.02 Jun 26, 2023
@johnhenley johnhenley modified the milestones: 08.00.02, 08.00.00 Jul 17, 2023
@johnhenley johnhenley modified the milestones: 08.00.02, 08.00.00 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnhenley johnhenley

Labels
technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Milestone
08.00.00
Development

Successfully merging a pull request may close this issue.

TASK: Update inconsistently-named variables johnhenley/Dnn.CommunityForums
1 participant
@johnhenley