Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Update inconsistently-named variables #331

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Incorrect naming conventions

Changes made

  • Update SiteId to PortalId
  • Update InstanceId to ModuleId

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is solved

Close #330

@johnhenley johnhenley added the technical debt Issue that doesn't directly affect usability but will improve technical debt posture label Jun 20, 2023
@johnhenley johnhenley added this to the 08.00.03 milestone Jun 20, 2023
@johnhenley johnhenley self-assigned this Jun 20, 2023
@johnhenley johnhenley modified the milestones: 08.00.03, 08.00.01, 08.00.02 Jun 26, 2023
@johnhenley johnhenley modified the milestones: 08.00.02, 08.00.00 Jul 17, 2023
@johnhenley johnhenley modified the milestones: 08.00.02, 08.00.00 Sep 13, 2023
@johnhenley
Copy link
Collaborator Author

@WillStrohl pulled forward to 08.00.00

Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit ee10656 into DNNCommunity:dev Sep 14, 2023
1 check passed
@johnhenley johnhenley deleted the modernize/siteid-instanceid branch September 14, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TASK: Inconsistent variable naming conventions
2 participants