Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Opening a forum post from the Viewer module opens the post in the main forum module instead #373

Closed
SiteSupportGuy opened this issue Jul 13, 2023 · 5 comments · Fixed by #397
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SiteSupportGuy
Copy link

Describe the bug

Opening a forum post from the Viewer module opens the post in the main forum module instead. This means the user does not stay on the forum page they started in.

Software Versions

  • DNN: 09.11.02
  • Module: 07.00.12

To Reproduce

Steps to reproduce the behavior:

  1. Create a page with the ActiveForums module on it
  2. Create another page with the ActiveForums viewer module on it
  3. Link the viewer to a forum from the main module
  4. Create a post in the viewer module
  5. You are now on the main forum page instead of the viewer
  6. Go back to the viewer module and click the forum post you just created
  7. You are once again on the main page instead

Expected behavior

The forum post should open in the page it was selected from.

Additional context

This issue is likely related to the recent fix to the viewer control panel. The fix to the panel has the user open the panel in the main page, which is what also happens to the forum posts.
I tested this locally and on our test site.

@WillStrohl
Copy link
Member

Thank you for reporting this. Without testing this use case myself, it definitely sounds like it's related to the recent update you're citing.

Just so you know, we're not currently planning to release another 7.xx version of the module. We're now working on v8.0. Much of the work is already done. However, this means that you'll need to wait for a major upgrade to receive this fix (should a fix be found and implemented).

@johnhenley
Copy link
Collaborator

Hi @SiteSupportGuy. I went back and tested this with the previous release (07.00.11) before the control panel change was added, and it works exactly the same way (goes to the main forums page). The viewer module was originally intended to provide a way to place (perhaps just selected) forums on a different page than the main forums module. I'm curious -- can you explain how you are using it where having it jump to a different page is problematic? The same security is still applied to both the viewer and the forums module. Again, I don't want you to think I'm being dismissive of your issue but want to better understand your use case before we attempt to fix. Also, we all greatly appreciate you taking the time to report this and for your continued support of the forums module!!

@SiteSupportGuy
Copy link
Author

Hello @johnhenley, I just tested 07.00.11 again locally. This version does not cause this issue to happen. When I open a forum post, it stays on the viewer's page and is not redirected.
My goal is to have the main forum module simply be a hub for admin use, while the viewer modules will be used in other parts of the site, linked with their respective topics.

@johnhenley
Copy link
Collaborator

OK. Are you using the friendly URLs option with the module?
I just did some more testing and it looks like it works the way you want in 07.00.11 but only if you disable friendly URLs.

07.00.11 -- friendly URL off - works as you want
07.00.11 -- friendly URL on -- goes back to main page
07.00.12 -- both goes back to main page.

@SiteSupportGuy
Copy link
Author

I am not using it, I do not have the Active Forums URL Handler installed either.

johnhenley added a commit to johnhenley/Dnn.CommunityForums that referenced this issue Aug 4, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Aug 4, 2023
@johnhenley johnhenley added bug Something isn't working and removed review in process labels Aug 4, 2023
@johnhenley johnhenley self-assigned this Aug 4, 2023
@johnhenley johnhenley changed the title Opening a forum post from the Viewer module opens the post in the main forum module instead BUG: Opening a forum post from the Viewer module opens the post in the main forum module instead Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants