Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Multiple emails if subscribed to both forum and topic #419

Closed
johnhenley opened this issue Aug 15, 2023 · 5 comments · Fixed by #535
Closed

BUG: Multiple emails if subscribed to both forum and topic #419

johnhenley opened this issue Aug 15, 2023 · 5 comments · Fixed by #535
Assignees
Labels
bug Something isn't working
Milestone

Comments

@johnhenley
Copy link
Collaborator

johnhenley commented Aug 15, 2023

Describe the bug

If you are subscribed to a forum and to a particular topic, you receive emails for each. In this case, only the topic subscription should be processed.

Software Versions

  • DNN: 09.12.00
  • Module: 07.00.12

To Reproduce

Steps to reproduce the behavior:

  1. As user 1, subscribe to a forum and to a topic in that forum.
  2. As user 2, post to that topic.
  3. User 1 will receive two notifications.

Expected behavior

Topic subscription should take precedence and forum subscription should be ignored.

Additional context

Issue introduced in 07.00.05? #207

@johnhenley johnhenley added the bug Something isn't working label Aug 15, 2023
@johnhenley johnhenley self-assigned this Aug 15, 2023
@johnhenley johnhenley changed the title BUG: Duplicated emails if subscribed to both forum and topic BUG: Multiple emails if subscribed to both forum and topic Aug 15, 2023
@johnhenley
Copy link
Collaborator Author

johnhenley commented Aug 15, 2023

@WillStrohl do you want this to go into 8.0? Or hold until later? It's not critical imho.

@DNNCommunity DNNCommunity deleted a comment from will Aug 15, 2023
@DNNCommunity DNNCommunity deleted a comment from Timo-Breumelhof Aug 15, 2023
@WillStrohl
Copy link
Member

@WillStrohl do you want this to go into 8.0? Or hold until later? It's not critical imho.

Let's wait until later. We have a big plate on our table already. 🤙🏽

@WillStrohl
Copy link
Member

Yeah, later would be better, I think. But, I've noticed this myself and didn't realize why it was happening. I thought it was because I was also an Admin or something.

@johnhenley
Copy link
Collaborator Author

Yeah, later would be better, I think. But, I've noticed this myself and didn't realize why it was happening. I thought it was because I was also an Admin or something.

@WillStrohl can we do it with 08.0.0.00 as @Timo-Breumelhof said this is only opportunity to get testers :)

@WillStrohl
Copy link
Member

When I sent that comment, I didn't realize there was already a PR. All good! 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants