Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More specific email notification subject lines #207

Merged
merged 6 commits into from
Feb 20, 2023

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Jan 18, 2023

Description of PR...

More specific email notification subject lines

Changes made

  • Stored procedure for subscribers returns topicsubscriber column (true if subscribed to a topic, false if subscribed to forum)
  • new email tokens

[NEWPOST] inserts text "new post" if not a reply
[NEWREPLY] inserts text "new reply" if a reply

[POSTEDTO] inserts text "posted to" if not a reply
[REPLIEDTO] inserts text "replied to" if a reply

[SUBSCRIBEDTOPIC] "Subscribed Topic"
[SUBSCRIBEDTOPICSUBJECT] "Subscribed Topic {subject}"
[SUBSCRIBEDTOPICFORUMNAME] "Subscribed Topic {subject} on Forum {forumname}"
[SUBSCRIBEDFORUM] "Subscribed Forum"
[SUBSCRIBEDFORUMNAME] "Subscribed Forum {forumname}"

  • Update default configuration to have this for email subject:
    [DISPLAYNAME] [POSTEDTO][REPLIEDTO] [SUBSCRIBEDTOPICFORUMNAME][SUBSCRIBEDFORUMNAME] on [PORTALNAME]

Sample subject lines

  1. A [NEWPOST][NEWREPLY] has been added to [FORUMNAME]
  2. A [NEWPOST][NEWREPLY] has been added to [SUBSCRIBEDTOPICFORUMNAME][SUBSCRIBEDFORUMNAME] on [PORTALNAME]
  3. [DISPLAYNAME] [POSTEDTO][REPLIEDTO] [SUBSCRIBEDTOPICFORUMNAME][SUBSCRIBEDFORUMNAME] on [PORTALNAME]
    results in:

a. A new post has been added to Sample Forum 2
b. A new reply has been added to Subscribed Forum Sample Forum 2 on My Website [for a forum subscriber]
c. A new reply to Subscribed Topic RE: I need help on Forum Questions and Answers on My Website [for a topic subscriber]
d. John User posted to Forum Questions and Answers on My Website[for a forum subscriber]
e. John User replied to Subscribed Topic RE: I need help on Forum Questions and Answers on My Website[for a topic subscriber]

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is solved

Close #169

… if subscribed to a topic, false if subscribed to forum)
new email tokens
[NEWPOST] inserts text "new post" if not a reply
[NEWREPLY] inserts text "new reply" if a reply

[SUBSCRIBEDTOPIC] "Subscribed Topic"
[SUBSCRIBEDTOPICSUBJECT] "Subscribed Topic {subject}"
[SUBSCRIBEDTOPICFORUMNAME] "Subscribed Topic {subject} on Forum {forumname}"
[SUBSCRIBEDFORUM] "Subscribed Forum"
[SUBSCRIBEDFORUMNAME] "Subscribed Forum {forumname}"
So....
you can have a subject like
A [NEWPOST][NEWREPLY] has been added to [FORUMNAME]
A [NEWPOST][NEWREPLY] has been added to [SUBSCRIBEDTOPICFORUMNAME][SUBSCRIBEDFORUMNAME] on [PORTALNAME]
@johnhenley johnhenley added the enhancement New feature or request label Jan 18, 2023
@johnhenley johnhenley self-assigned this Jan 18, 2023
@johnhenley johnhenley added this to the 07.00.05 milestone Jan 18, 2023
@johnhenley
Copy link
Collaborator Author

@WillStrohl I made this one 07.00.05 since it has a sql update and don't want to disturb the other pull requests that are still outstanding. Feel free to pull into another one if you want--you will just need to deal with the SqlProvider file.

johnhenley and others added 2 commits February 13, 2023 15:21
[POSTEDTO] inserts text "posted to" if not a reply
[REPLIEDTO] inserts text "replied to" if a reply

subscribed email subject for new installs:
[DISPLAYNAME] [POSTEDTO][REPLIEDTO] [SUBSCRIBEDTOPICFORUMNAME][SUBSCRIBEDFORUMNAME] on [PORTALNAME]
@WillStrohl WillStrohl merged commit 202e32d into DNNCommunity:dev Feb 20, 2023
@johnhenley johnhenley deleted the issues/169 branch February 22, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More specific email notifications
2 participants