Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Stop setting runAllManagedModulesForAllRequests on the <modules> tag in web.config #439

Closed
johnhenley opened this issue Sep 8, 2023 · 1 comment · Fixed by #440
Closed
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@johnhenley
Copy link
Collaborator

stop setting runAllManagedModulesForAllRequests on the <modules> tag in web.config

This is done when the URL rewriter is installed.

Based on this page, this setting is not required if IIS 7 (with patch) or IIS 8+ are used.

https://learn.microsoft.com/en-us/iis/configuration/system.webserver/modules/

image

We will not remove from existing web.config settings, since it could hav been added by some other module or manually by an administrator.

We will:

  • Remove logic to set attribute
  • Add guidance to release notes
  • Add guidance to wiki page
@johnhenley johnhenley changed the title Stop setting runAllManagedModulesForAllRequests on the <modules> tag in web.config ENH: Stop setting runAllManagedModulesForAllRequests on the <modules> tag in web.config Sep 8, 2023
@WillStrohl
Copy link
Member

Such a great catch... Thanks @johnhenley! 💪🏽

@WillStrohl WillStrohl added the enhancement New feature or request label Sep 8, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Sep 13, 2023
@johnhenley johnhenley self-assigned this Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants