Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Don't set runAllManagedModulesForAllRequest in web.config #440

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Sep 8, 2023

Description of PR...

runAllManagedModulesForAllRequest=true in web.config no longer needed with IIS 7 (plus patch) or IIS 8+

Changes made

  • don't set runAllManagedModulesForAllRequests="true" in web.config when installing rewriter
  • add instructions to release notes to manually remove
    image

PR Template Checklist

Please mark which issue is solved

Close #439

…ig when installing friendly URL provider

TASK: update release notes with instructions on removing it manually
@johnhenley johnhenley added the tasks General maintenance tasks that aren't typical development label Sep 8, 2023
@johnhenley johnhenley self-assigned this Sep 8, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Sep 13, 2023
@johnhenley
Copy link
Collaborator Author

@WillStrohl I pulled this forward to 08.00.00

Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit 19d1dc2 into DNNCommunity:dev Sep 13, 2023
1 check passed
@johnhenley johnhenley deleted the issues/439-runAllManagedModulesForAllRequests branch September 13, 2023 21:28
@johnhenley johnhenley changed the title Don't set runAllManagedModulesForAllRequest in web.config ENH: Don't set runAllManagedModulesForAllRequest in web.config Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks General maintenance tasks that aren't typical development
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Stop setting runAllManagedModulesForAllRequests on the <modules> tag in web.config
2 participants