Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced search Title is not wrapped in an element #481

Closed
Timo-Breumelhof opened this issue Sep 20, 2023 · 2 comments · Fixed by #495
Closed

Advanced search Title is not wrapped in an element #481

Timo-Breumelhof opened this issue Sep 20, 2023 · 2 comments · Fixed by #495
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Sep 20, 2023

Is your feature request related to a problem?

Please describe.
All titles seem to follow the standard that the text is wrapped in an element.
In most cases it's a span with a class (instead of an actual heading but that's another issue)
But the one in advanced search is not wrapped at all but in it's parent element.
See:

image

All other titles have this:

image

Describe the solution you'd like

Add the same wrapper all other titles use
So <span class="af-adv-search-title">Topics</span>

@Timo-Breumelhof Timo-Breumelhof added the enhancement New feature or request label Sep 20, 2023
@Timo-Breumelhof Timo-Breumelhof added this to the 08.00.00 milestone Sep 20, 2023
@Timo-Breumelhof Timo-Breumelhof self-assigned this Sep 20, 2023
@Timo-Breumelhof
Copy link
Contributor Author

For some reason a literal was used instead of a label (which is good, but not the same as the other titles)

<div class='af-adv-search-header'><asp:Literal runat="server" ID="litOptions" /></div>

@johnhenley
Copy link
Collaborator

is this what you want?

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants