Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: change div to span in search header #495

Merged
merged 4 commits into from
Sep 21, 2023
Merged

ENH: change div to span in search header #495

merged 4 commits into from
Sep 21, 2023

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Sep 20, 2023 •
edited
Loading

Description of PR...

ENH: change div to span in search header

PR Template Checklist

  • [] Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #481

@johnhenley
ENH: change div to span in search header
ac1a5c7 
FIX: "minisearch" needs to know tabid to pass to url generator
@johnhenley johnhenley added bug Something isn't working enhancement New feature or request labels Sep 20, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Sep 20, 2023
@johnhenley johnhenley self-assigned this Sep 20, 2023
Timo-Breumelhof
Timo-Breumelhof requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@Timo-Breumelhof Timo-Breumelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "title" is used elsewhere.
I would use af-adv-search-title

@johnhenley
Copy link
Collaborator Author

I think "title" is used elsewhere. I would use af-adv-search-title

I just changed the div to span

WillStrohl
WillStrohl approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit cdcccf6 into DNNCommunity:dev Sep 21, 2023
1 check passed
@johnhenley johnhenley deleted the issues/481-search-label branch September 21, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

@Timo-Breumelhof Timo-Breumelhof Awaiting requested review from Timo-Breumelhof

Assignees

@johnhenley johnhenley

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
08.00.00
Development

Successfully merging this pull request may close these issues.

Advanced search Title is not wrapped in an element
3 participants
@johnhenley @WillStrohl @Timo-Breumelhof