Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make toolbar icons more clear #550

Closed
Timo-Breumelhof opened this issue Oct 10, 2023 · 4 comments · Fixed by #573
Closed

Make toolbar icons more clear #550

Timo-Breumelhof opened this issue Oct 10, 2023 · 4 comments · Fixed by #573
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Timo-Breumelhof commented Oct 10, 2023

Is your feature request related to a problem?

Please describe.
See:
image

I think this would be better:

image

Describe the solution you'd like

<a href="https://dnnmoduletest3.tb.40fdev.me/activeforums/"><i class="fa fa-home fa-fw fa-blue"></i><span class="dcf-link-text">Forums</span>
<a href="https://dnnmoduletest3.tb.40fdev.me/activeforums/Home/afv/grid/afgt/unanswered"><i class="fa fa-comment-o fa-fw fa-blue"></i><span class="dcf-link-text">Unanswered</span>
<a href="https://dnnmoduletest3.tb.40fdev.me/activeforums/Home/afv/grid/afgt/notread"><i class="fa fa-eye-slash fa-fw fa-grey"></i><span class="dcf-link-text">Not Read</span>
<a href="https://dnnmoduletest3.tb.40fdev.me/activeforums/Home/afv/grid/afgt/mytopics"><i class="fa fa-user fa-fw fa-grey"></i><span class="dcf-link-text">My Topics</span>
<a href="https://dnnmoduletest3.tb.40fdev.me/activeforums/Home/afv/grid/afgt/activetopics"><i class="fa fa-fire fa-fw fa-grey"></i><span class="dcf-link-text">Active Topics</span>

@Timo-Breumelhof Timo-Breumelhof added the enhancement New feature or request label Oct 10, 2023
@Timo-Breumelhof Timo-Breumelhof added this to the 08.00.00 milestone Oct 10, 2023
@johnhenley
Copy link
Collaborator

@Timo-Breumelhof the icon choices look fine. I can make them in the code if you send me the classes. However,
thinking about this more in light of our conversation yesterday and how everything should be "templatable". Particularly the two toolbars. I really cringe and resist trading out one FA class for another one which requires code change and recompile etc. Doing it properly gives designers the option to swap icons on their own if they choose. Do we take this on now or defer?

@WillStrohl
Copy link
Member

Good question... I'm leaning toward putting it off to see if there is any demand for it. There's no sense in spending the time if no one will notice.

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley I agree for version 9 ok? ;-)

@johnhenley
Copy link
Collaborator

Sorry I might have been unclear.

We can change the icons now to ones that @Timo-Breumelhof chose because they are more appropriate. That's easy enough.

I agree we shouldn't update to a different method of selecting an icon (i.e., doing it completely in the css rather than emitting an fa-xx class from code) until a future release and we all agree it's worthwhile. And I'm way out of my league here.

Timo-Breumelhof pushed a commit to Timo-Breumelhof/Dnn.CommunityForums that referenced this issue Oct 23, 2023
Timo-Breumelhof added a commit that referenced this issue Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants