Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review caching strategies #724

Closed
johnhenley opened this issue Mar 29, 2024 · 0 comments · Fixed by #777
Closed

Review caching strategies #724

johnhenley opened this issue Mar 29, 2024 · 0 comments · Fixed by #777
Assignees
@johnhenley
Labels
dependencies Pull requests that update a dependency file performance An update likely to improve site performance technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Milestone
08.01.00

Comments

@johnhenley
Copy link
Collaborator

Caching was significantly updated in 8.0, focused on:

  • centralizing caching logic and cache keys
  • separation of caches for settings/metadata vs content
  • separation of caches by module-instance so multiple forum instances in same or separate portals aren't in same cache

In 8.1, significant updates are moving database logic to DAL2 APIs, which provides its own caching.

Actions:

  • Remove unnecessary caching for simple objects
  • Continue caching more complex, calculated, or nested objects
    • keep using DAL2 GetById() but pass ModuleId when creating controllers so (overriding) GetById() method can put complex results into module-specific cache

Related to #266
@johnhenley johnhenley self-assigned this Mar 29, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Mar 29, 2024
@johnhenley johnhenley added dependencies Pull requests that update a dependency file technical debt Issue that doesn't directly affect usability but will improve technical debt posture performance An update likely to improve site performance labels Mar 29, 2024
@johnhenley johnhenley mentioned this issue Apr 30, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnhenley johnhenley

Labels
dependencies Pull requests that update a dependency file performance An update likely to improve site performance technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Milestone
08.01.00
Development

Successfully merging a pull request may close this issue.

TASK: Final tweaks before 8.1 johnhenley/Dnn.CommunityForums
1 participant
@johnhenley