Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/Modernize Entities and Controllers #266

Closed
johnhenley opened this issue Mar 31, 2023 · 1 comment · Fixed by #746, #751, #735, #736 or #737
Closed

Refactor/Modernize Entities and Controllers #266

johnhenley opened this issue Mar 31, 2023 · 1 comment · Fixed by #746, #751, #735, #736 or #737
Assignees
Labels
broad scope Non-specific issues that address multiple areas epic Placeholder for large development which may include multiple issues and/or pull requests performance An update likely to improve site performance technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Milestone

Comments

@johnhenley
Copy link
Collaborator

johnhenley commented Mar 31, 2023

Description of task

Wherever possible, refactor/modernize entities and controllers to use more modern DNN practices, such as DAL2, and modern C# features, such as generics.

  • move entities to an Entities folder/namespace
  • move controllers to Controllers folder/namespace
  • mark old classes for future deprecation and use inheritance to handle any legacy consumers of a public method
  • update existing code to use new classes

An example controller upgrade:
image

An example entity upgrade:
image

This issue is a placeholder/reference for related pull requests.

What general area(s)/component(s) are affected?

[] User interface
[X] Database schema
[X] Business Logic
[] Dependencies
[] Installation/manifest

@johnhenley johnhenley added technical debt Issue that doesn't directly affect usability but will improve technical debt posture performance An update likely to improve site performance epic Placeholder for large development which may include multiple issues and/or pull requests broad scope Non-specific issues that address multiple areas labels Mar 31, 2023
@johnhenley johnhenley changed the title Refactor/Modernize Entities and Controller Refactor/Modernize Entities and Controllers Mar 31, 2023
@johnhenley johnhenley self-assigned this Jul 13, 2023
@johnhenley johnhenley added this to the 08.01.00 milestone Mar 1, 2024
@johnhenley
Copy link
Collaborator Author

All refactoring completed for 08.01.00 release; will open new issues for future releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment