Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ModuleId to activeforums_Permissions #726

Closed
johnhenley opened this issue Apr 2, 2024 · 0 comments · Fixed by #1016 or #1020
Closed

Add ModuleId to activeforums_Permissions #726

johnhenley opened this issue Apr 2, 2024 · 0 comments · Fixed by #1016 or #1020
Assignees
Labels
tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Milestone

Comments

@johnhenley
Copy link
Collaborator

johnhenley commented Apr 2, 2024

Ref: https://github.com/DNNCommunity/Dnn.CommunityForums/wiki/Database-model

Note: do this prior to #650

Improve database integrity by adding ModuleId to Permissions table. Permissions are assigned to Forums and/or Forum Groups but are not removed when module instance is deleted. Only way to remove them is manually via SQL. This also is inconsistent with DAL2 scope and caching.

Database Tasks:

  • Add ModuleId column allowing null
  • Populate ModuleId from existing Forums/ForumGroups.
  • Remove any orphans
  • Alter ModuleId not null
  • Add index on ModuleId
  • Add FK between Modules and activeforums_Permissions

Code tasks:

  • Populate ModuleId
  • Use moduleId for scoping when using Get() and GetById()
@johnhenley johnhenley added tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture labels Apr 2, 2024
@johnhenley johnhenley added this to the 08.02.00 milestone Apr 2, 2024
@johnhenley johnhenley self-assigned this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
1 participant