Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backwards wording on "subscribe to topic" messaging when replying to a new topic #753

Closed
ChrisHammond opened this issue Apr 17, 2024 · 3 comments · Fixed by #756
Closed
Assignees
Labels
question Further information is requested requires more information More information is required to duplicate or understand the issue. review in process Issue noted and currently being triaged/reviewed by developer
Milestone

Comments

@ChrisHammond
Copy link

Describe the bug

When you reply to a topic/thread, the checkbox to subscribe you to the thread is checked, but reads "unsubscribe from topic" which would lead the user to believe that they are unsubscribing (to something they haven't subscribed to yet.

Software Versions

Whatever is on dnncommunity.org

To Reproduce

Steps to reproduce the behavior:

  1. Go to 'a forum post'
  2. Click on 'quick reply message'
  3. Scroll down to 'bottom'
  4. See checkbox

Expected behavior

Change the wording to "Subscribe to thread" when it is checked. When it is unchecked, leave the wording the same. No need to change the wording, the act of CHECKING the box is sufficient.

Screenshots

image
@Timo-Breumelhof
Copy link
Contributor

@ChrisHammond hmm, good point.

@johnhenley
Copy link
Collaborator

@ChrisHammond @Timo-Breumelhof you are subscribing to future replies, so "topic"+"replies" = what? "Thread"? "Discussion"?

@johnhenley
Copy link
Collaborator

As for the backwards behavior, that is related to an autosubscribe option in the user profile and being changed in next release via PR #643. But I'm writing up an additional change to go a little further to properly handle multiple replies which would keep resubscribing you every time you reply.

@johnhenley johnhenley added question Further information is requested requires more information More information is required to duplicate or understand the issue. review in process Issue noted and currently being triaged/reviewed by developer labels Apr 17, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone May 10, 2024
@johnhenley johnhenley self-assigned this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested requires more information More information is required to duplicate or understand the issue. review in process Issue noted and currently being triaged/reviewed by developer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants