Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: changes to subscription options #756

Merged
merged 3 commits into from
Apr 18, 2024
Merged

ENH: changes to subscription options #756

merged 3 commits into from
Apr 18, 2024

Conversation

johnhenley
Copy link
Collaborator

@johnhenley johnhenley commented Apr 17, 2024 •
edited
Loading

Description of PR...

Minor UI changes for topic/forum subscriptions

Changes made

  • Changes 'subscribe/unsubscribe' to simply be 'subscribe' as the checkbox itself is the state
  • When a user has "subscribe" user preference checked, hide topic/reply subscription option since user will always be subscribed.

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #753

@johnhenley johnhenley added the enhancement New feature or request label Apr 17, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Apr 17, 2024
@johnhenley johnhenley self-assigned this Apr 17, 2024
Timo-Breumelhof
Timo-Breumelhof reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Timo-Breumelhof Timo-Breumelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question:
Do we need
"Subscribe to this discussion thread"
Isn't just
"Subscribe to this thread" enough?

@johnhenley
Copy link
Collaborator Author

One question:

Do we need

"Subscribe to this discussion thread"

Isn't just

"Subscribe to this thread" enough?

How about just "Subscribe"?

@Timo-Breumelhof
Copy link
Contributor

yes :-)

@johnhenley
Copy link
Collaborator Author

yes :-)

Done.

WillStrohl
WillStrohl approved these changes Apr 18, 2024
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit b70daa2 into DNNCommunity:dev Apr 18, 2024
1 check passed
@ChrisHammond
Copy link

WOOT! Thank you!

@johnhenley johnhenley deleted the issues/subscribe-to-topic-improvements-753 branch April 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timo-Breumelhof Timo-Breumelhof Timo-Breumelhof left review comments

@WillStrohl WillStrohl WillStrohl approved these changes

Assignees

@johnhenley johnhenley

Labels
enhancement New feature or request
Projects
None yet
Milestone
08.01.00
Development

Successfully merging this pull request may close these issues.

Backwards wording on "subscribe to topic" messaging when replying to a new topic
4 participants
@johnhenley @Timo-Breumelhof @ChrisHammond @WillStrohl