Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Default theme > Align Subscribers to the right #765

Closed
Timo-Breumelhof opened this issue Apr 23, 2024 · 5 comments · Fixed by #767
Closed

ENH: Default theme > Align Subscribers to the right #765

Timo-Breumelhof opened this issue Apr 23, 2024 · 5 comments · Fixed by #767
Assignees
Labels
enhancement New feature or request themes Dnn Community Forums Themes
Milestone

Comments

@Timo-Breumelhof
Copy link
Contributor

Is your feature request related to a problem?

Please describe.
image

@Timo-Breumelhof Timo-Breumelhof added enhancement New feature or request themes Dnn Community Forums Themes labels Apr 23, 2024
@Timo-Breumelhof Timo-Breumelhof added this to the 08.01.00 milestone Apr 23, 2024
@Timo-Breumelhof Timo-Breumelhof self-assigned this Apr 23, 2024
@johnhenley
Copy link
Collaborator

@Timo-Breumelhof thank you. That's been bugging me 😀

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley I think we should probably also change the "dcf-subscribe" CSS Class to "dcf-topic-subscribe"?

image

Timo-Breumelhof added a commit to Timo-Breumelhof/Dnn.CommunityForums that referenced this issue Apr 23, 2024
Timo-Breumelhof added a commit that referenced this issue Apr 23, 2024
…ibersRight

Default theme: subscribe alignment right #765
@johnhenley
Copy link
Collaborator

@johnhenley I think we should probably also change the "dcf-subscribe" CSS Class to "dcf-topic-subscribe"?

image

It looks like we have 'dcf-forum-subscribe' (for forums) vs 'dcf-subscribe' (for topics). Should we have two (changing dcf-subscribe to dcf-topic-subscribe)? Or should both use 'dcf-subscribe' and only need one?

@Timo-Breumelhof
Copy link
Contributor Author

@johnhenley it's always good to be able to make a distinction.
The ideal option is dcf-subscribe for everything related and en extra class with a specific class for that item

like: dcf-subscribe dcf-forum-subscribe

@johnhenley
Copy link
Collaborator

@johnhenley it's always good to be able to make a distinction. The ideal option is dcf-subscribe for everything related and en extra class with a specific class for that item

like: dcf-subscribe dcf-forum-subscribe

ok. if you want to change, you can change QuickReply.ascx and TopicView.ascx templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request themes Dnn Community Forums Themes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants