Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Bad redirect when replying and using friendly URL rewriter #337

Merged
merged 1 commit into from
Jun 23, 2023
Merged

FIX: Bad redirect when replying and using friendly URL rewriter #337

merged 1 commit into from
Jun 23, 2023

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

FIX: Bad redirect when replying and using friendly URL rewriter
(CONTINUATION of #325)

Changes made

  • In reply posting, check if friendly URLs are used, and redirect to reply using #xxxx rather than &afc=xxxx

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other

Please mark which issue is solved

Close #324

@johnhenley johnhenley added the bug Something isn't working label Jun 22, 2023
@johnhenley johnhenley added this to the 07.00.11 milestone Jun 22, 2023
@johnhenley johnhenley self-assigned this Jun 22, 2023
WillStrohl
WillStrohl approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@WillStrohl WillStrohl merged commit 96f7ef8 into DNNCommunity:dev Jun 23, 2023
1 check passed
@johnhenley johnhenley deleted the issues/friendly-url-replies-redirect-error branch June 23, 2023 21:16
@johnhenley johnhenley changed the title BUG: Bad redirect when replying and using friendly URL rewriter FIX: Bad redirect when replying and using friendly URL rewriter Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

Assignees

@johnhenley johnhenley

Labels
bug Something isn't working
Projects
None yet
Milestone
07.00.11
Development

Successfully merging this pull request may close these issues.

Redirect fails when replying and using friendly URL rewriter
2 participants
@johnhenley @WillStrohl