Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load FontAwesome locally rather than from CDN #599

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Load FontAwesome locally rather than from CDN #599

merged 4 commits into from
Nov 14, 2023

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Load FontAwesome font resources locally rather than from CDN.

Changes made

  • Add FontAwesome 4.7 to project
  • Load CSS using DNN Client Resource Manager

How did you test these updates?

Local install

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #556

@johnhenley johnhenley added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 14, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Nov 14, 2023
@johnhenley johnhenley self-assigned this Nov 14, 2023
@johnhenley
Copy link
Collaborator Author

johnhenley commented Nov 14, 2023 •
edited
Loading

@Timo-Breumelhof to review MimeType issue in web.config for woff2 fonts.
image

WillStrohl
WillStrohl approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit b9b1e92 into DNNCommunity:dev Nov 14, 2023
1 check passed
@johnhenley johnhenley deleted the issues/556-font-awesome-no-cdn branch November 14, 2023 19:36
@johnhenley
Copy link
Collaborator Author

@Timo-Breumelhof reminder to look at woff2 mime type issue. Not specific for Forums, but also affects skins and floods the admin logs....
image

@johnhenley
Copy link
Collaborator Author

@Timo-Breumelhof to review MimeType issue in web.config for woff2 fonts.

image

@timo

@johnhenley johnhenley mentioned this pull request May 27, 2024
Closed
@johnhenley johnhenley mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

@Timo-Breumelhof Timo-Breumelhof Awaiting requested review from Timo-Breumelhof

Assignees

@johnhenley johnhenley

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
08.00.00
Development

Successfully merging this pull request may close these issues.

ENH: Install and load FontAwesome locally rather than from CDN
2 participants
@johnhenley @WillStrohl