Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Topic Subscribe/Quick Reply Subscribe checkboxes have different values #653

Merged

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Standardize conflicting subscribe checkbox logic when user profile is set to auto-subscribe to posts and replies.

Changes made

  • relocate user autosubscription logic to only be applied when posting or replying to a topic, not when viewing a topic
  • Standardize subscribe checkbox logic

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #649

ENH: relocate user autosubscription logic to only be applied when posting or replying to a topic, not when viewing a topic
@johnhenley johnhenley added bug Something isn't working enhancement New feature or request labels Jan 16, 2024
@johnhenley johnhenley added this to the 08.00.02 milestone Jan 16, 2024
@johnhenley johnhenley self-assigned this Jan 16, 2024
ENH: relocate user autosubscription logic to only be applied when posting or replying to a topic, not when viewing a topic
@johnhenley johnhenley changed the title FIX: FIX: Topic Subscribe/Quick Reply Subscribe checkboxes have different values Jan 30, 2024
@johnhenley johnhenley modified the milestones: 08.00.02, 08.01.00 Feb 9, 2024
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit d5a7eaf into DNNCommunity:dev Feb 14, 2024
1 check passed
@johnhenley johnhenley deleted the issues/subscribe-checkboxes-649 branch February 14, 2024 02:23
@johnhenley johnhenley restored the issues/subscribe-checkboxes-649 branch February 21, 2024 16:28
@johnhenley
Copy link
Collaborator Author

@WillStrohl This PR still has the 8.0.2. SQL file not the 8.1 SQL file. Have I told you how much I don't like merge conflicts for the SQL files? :) I am going to open another PR to move this SQL from 8.0.2 to 8.1.

@johnhenley johnhenley deleted the issues/subscribe-checkboxes-649 branch February 21, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topic Subscribe/Quick Reply Subscribe checkboxes have different values
2 participants