Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TASK: Use constants rather than "-1" & "-3" for DNN "all users" and "unauthenticated" users #663

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Refactoring to use constants rather than hard-coded values

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

@johnhenley johnhenley added tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture labels Feb 14, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Feb 14, 2024
@johnhenley johnhenley self-assigned this Feb 14, 2024
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit 18d1446 into DNNCommunity:dev Feb 14, 2024
1 check passed
@johnhenley johnhenley deleted the dev81/1-refactoring/3-constants-registeredusers-administrators branch February 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks General maintenance tasks that aren't typical development technical debt Issue that doesn't directly affect usability but will improve technical debt posture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants