Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Show theme and template folder in Control Panel templates list #668

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Add theme name and template folder to Control Panel templates list

Changes made

  • UI updates
  • Added resource strings to ControlPanel.resx:
    • [RESX:Template]
    • [RESX:Theme]
  • Added resource strings to SharedResources.resx:
    • [RESX:Folder]

How did you test these updates?

Local install
image

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #569

@johnhenley johnhenley added the enhancement New feature or request label Feb 16, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Feb 16, 2024
@johnhenley johnhenley self-assigned this Feb 16, 2024
Copy link
Contributor

@Timo-Breumelhof Timo-Breumelhof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition :-)

@Timo-Breumelhof
Copy link
Contributor

@johnhenley Hmm, I guess I should have merged them in another order :-(

@johnhenley
Copy link
Collaborator Author

@johnhenley Hmm, I guess I should have merged them in another order :-(
Merge conflicts seem to be my specialty :)
That's why I usually only do one PR at a time.
Try this one again. Then do PR #664, #665, and #666. Then I will resync again and push another one.

@Timo-Breumelhof Timo-Breumelhof merged commit 56fdfa5 into DNNCommunity:dev Feb 21, 2024
1 check passed
@Timo-Breumelhof
Copy link
Contributor

@johnhenley done

@johnhenley johnhenley deleted the dev81/2-features/show-theme-in-control-panel-569 branch February 21, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Show current Theme when editing Templates
2 participants