Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Can't subscribe when adding new topic #698

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Subscribing not working when adding a new topic

Changes made

  • Change posting form to use server-side checkbox when adding a new topic
  • Change JavaScript to not call subscribe API when adding a new topic

How did you test these updates?

Local install; tested adding new topic and replying to existing topics

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #697

@johnhenley johnhenley added the bug Something isn't working label Mar 7, 2024
@johnhenley johnhenley added this to the 08.01.00 milestone Mar 7, 2024
@johnhenley johnhenley self-assigned this Mar 7, 2024
@Timo-Breumelhof Timo-Breumelhof merged commit d91f45a into DNNCommunity:dev Mar 12, 2024
1 check passed
@johnhenley johnhenley deleted the issues/cant-subscribe-to-unsaved-topic-697 branch March 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Error from the browser while subscribing to a new topic
2 participants